Skip to content

X.509 Interop Test#989

Open
ejohnstown wants to merge 4 commits into
wolfSSL:masterfrom
ejohnstown:x509-interop
Open

X.509 Interop Test#989
ejohnstown wants to merge 4 commits into
wolfSSL:masterfrom
ejohnstown:x509-interop

Conversation

@ejohnstown
Copy link
Copy Markdown
Contributor

  • Add a GitHub Actions workflow that builds PKIX-SSH and runs wolfSSHd against the PKIX-SSH ssh/sftp clients to exercise x509 user-certificate auth; runs weekly and on workflow_dispatch.
  • Gate wolfSSH/wolfSSL debug logging in wolfsshd behind the -d flag, enabling it on startup and disabling both facilities during cleanup.

Copilot AI review requested due to automatic review settings May 22, 2026 17:04
@ejohnstown ejohnstown changed the title X509 interop X.509 Interop Test May 22, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an automated X.509 interop validation loop to the repo and adjusts wolfSSHd logging behavior so wolfSSH/wolfSSL debug output is only enabled when explicitly requested via -d.

Changes:

  • Add a scheduled/manual GitHub Actions workflow to build PKIX-SSH and run ssh/sftp interop tests against wolfSSHd using X.509 user-certificate auth.
  • Gate wolfSSL_Debugging_ON() behind the -d flag and add explicit debug shutdown during wolfSSHd cleanup.
  • Enable wolfSSH debug logging on -d (currently guarded by DEBUG_WOLFSSH).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
apps/wolfsshd/wolfsshd.c Moves wolfSSL debug enabling behind -d and adds debug OFF calls during cleanup.
.github/workflows/x509-interop.yml New weekly/manual CI workflow to build PKIX-SSH + wolfSSL and run X.509 ssh/sftp interop against wolfSSHd.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/wolfsshd/wolfsshd.c Outdated
Comment thread .github/workflows/x509-interop.yml
- Enable wolfSSH/wolfSSL debug logging only when -d is passed
- Disable both logging facilities during cleanup
- Build PKIX-SSH and run wolfSSHd against the PKIX-SSH ssh/sftp
  clients using x509 user certs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants