X.509 Interop Test#989
Open
ejohnstown wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an automated X.509 interop validation loop to the repo and adjusts wolfSSHd logging behavior so wolfSSH/wolfSSL debug output is only enabled when explicitly requested via -d.
Changes:
- Add a scheduled/manual GitHub Actions workflow to build PKIX-SSH and run ssh/sftp interop tests against
wolfSSHdusing X.509 user-certificate auth. - Gate
wolfSSL_Debugging_ON()behind the-dflag and add explicit debug shutdown duringwolfSSHdcleanup. - Enable wolfSSH debug logging on
-d(currently guarded byDEBUG_WOLFSSH).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/wolfsshd/wolfsshd.c | Moves wolfSSL debug enabling behind -d and adds debug OFF calls during cleanup. |
| .github/workflows/x509-interop.yml | New weekly/manual CI workflow to build PKIX-SSH + wolfSSL and run X.509 ssh/sftp interop against wolfSSHd. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Enable wolfSSH/wolfSSL debug logging only when -d is passed - Disable both logging facilities during cleanup
- Build PKIX-SSH and run wolfSSHd against the PKIX-SSH ssh/sftp clients using x509 user certs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-dflag, enabling it on startup and disabling both facilities during cleanup.