Skip to content

spec: Materialize SUB in sub.toml for improved machine-readability#695

Open
RobinJadoul wants to merge 1 commit into
spec/mainfrom
spec/explicit-sub
Open

spec: Materialize SUB in sub.toml for improved machine-readability#695
RobinJadoul wants to merge 1 commit into
spec/mainfrom
spec/explicit-sub

Conversation

@RobinJadoul

Copy link
Copy Markdown
Collaborator

No description provided.

@RobinJadoul RobinJadoul requested a review from erik-3milabs June 22, 2026 15:30
@RobinJadoul RobinJadoul self-assigned this Jun 22, 2026
@RobinJadoul RobinJadoul added the spec Updates and improvements to the spec document label Jun 22, 2026
@github-actions

Copy link
Copy Markdown

Kimi Code Review

⚠️ Review failed: Kimi API request failed with status 401


Automated review by Kimi (Moonshot AI)

@github-actions

Copy link
Copy Markdown

Codex Code Review

No issues found in the PR diff.

I reviewed the SUB spec addition and the add.typ documentation changes. The new SUB constraint correctly maps to ADD<lhs; diff, rhs>, enforcing diff = lhs - rhs mod 2^64, and the assumptions cover the operands required by the underlying ADD.

Verification run:
python3 spec/tooling/chip.py spec/src/config.toml spec/src/signatures.toml spec/src/*.toml passed.

I could not run Typst rendering because typst is not installed in this environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spec Updates and improvements to the spec document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant