fix: make ShardingCodec equality work with rng field (#4005)#4007
Open
NIK-TIGER-BILL wants to merge 1 commit into
Open
fix: make ShardingCodec equality work with rng field (#4005)#4007NIK-TIGER-BILL wants to merge 1 commit into
NIK-TIGER-BILL wants to merge 1 commit into
Conversation
…#4005) ShardingCodec gained a field in a recent commit. Because does not implement , the auto-generated dataclass always returned when was not . This patch adds custom and methods that compare Generators by their , restoring deterministic equality for otherwise-identical codec instances. Closes zarr-developers#4005 Signed-off-by: NIK-TIGER-BILL <nik.tiger.bill@github.com>
github-actions
Bot
added
the
needs release notes
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4007 +/- ##
==========================================
- Coverage 93.49% 93.47% -0.03%
==========================================
Files 88 88
Lines 11873 11889 +16
==========================================
+ Hits 11101 11113 +12
- Misses 772 776 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the equality comparison for
ShardingCodecwhen therngfield is present.Because
np.random.Generatordoes not implement__eq__, the auto-generated dataclass__eq__always returnedFalsewhenrngwas notNone, even for two identical codec instances.Changes:
__eq__that comparesnp.random.Generatorobjects by theirbit_generator.state.__hash__that hashes the same state.Nonecases.Closes #4005