Skip to content

Fix #5879: Selecting processes for deletion doesn't highlight all#5880

Merged
tdonohue merged 1 commit into
DSpace:mainfrom
atmire:w2p-142794_fix-even-deletion-selection-highlighting
Jul 1, 2026
Merged

Fix #5879: Selecting processes for deletion doesn't highlight all#5880
tdonohue merged 1 commit into
DSpace:mainfrom
atmire:w2p-142794_fix-even-deletion-selection-highlighting

Conversation

@bram-maegerman

Copy link
Copy Markdown
Contributor

References

Fixes #5879

Description

Forces all selected processes for deletion to be have the table-danger color applied instead of just the odd ones on the process overview page.

Instructions for Reviewers

Go to {ui}/processes
Select the first an second process in the overview
Notice both processes are highlighted in red

List of changes in this PR:

  • Added a css rule to force the red color on table rows marked with .table-danger on the process overview page.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added improvement component: administrative tools Related to the admin menu or tools 1 APPROVAL pull request only requires a single approval to merge ux User Experience related works labels Jun 30, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Jun 30, 2026

@tinsch tinsch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR and can confirm that it fixes the highlighting bug 👍

@tdonohue tdonohue added the port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release label Jul 1, 2026

@tdonohue tdonohue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @bram-maegerman ! This looks good and has been tested by @tinsch . I've verified this issue also occurs on demo.dspace.org, so I'm merging this into both main and dspace-10_x.

(If anyone notices this same issue in 9.x or 8.x, then we'll have to backport those fixes manually via a separate backport PR)

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 11.0 Release Jul 1, 2026
@tdonohue tdonohue added this to the 11.0 milestone Jul 1, 2026
@tdonohue tdonohue merged commit 0c2eae4 into DSpace:main Jul 1, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 11.0 Release Jul 1, 2026
@dspace-bot

Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-10_x:

@tdonohue tdonohue removed the port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge component: administrative tools Related to the admin menu or tools improvement ux User Experience related works

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Selecting processes for deletion doesn't highlight all

5 participants