Skip to content

Add AGPL-3.0-or-later license and Chinese README#1

Merged
Milvona merged 1 commit into
mainfrom
codex/agpl3readme.md
Jun 19, 2026
Merged

Add AGPL-3.0-or-later license and Chinese README#1
Milvona merged 1 commit into
mainfrom
codex/agpl3readme.md

Conversation

@Milvona

@Milvona Milvona commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Motivation

  • 添加项目许可证以明确开源条款,并提供中文 README.md 来说明项目用途、功能和构建说明。

Description

  • 新增 LICENSE 文件,包含 GNU Affero General Public License v3.0 或更高版本的声明并包含 SPDX-License-Identifier: AGPL-3.0-or-later,同时新增中文 README.md,涵盖项目概览、功能概览、环境与依赖、构建步骤、产物布局、项目结构、开发说明和许可证引用。

Testing

  • 运行 git diff --check 以检测不一致问题,检查通过。

Codex Task

@Milvona Milvona marked this pull request as ready for review June 19, 2026 15:14
@Milvona Milvona merged commit ad4c623 into main Jun 19, 2026
1 check failed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50276d62a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md
@@ -0,0 +1,62 @@
# ModAPI

ModAPI 是 GroupMountain 维护的 Minecraft Bedrock Dedicated Server 模组开发接口库,面向基于 LeviLamina 与 GMLIB 的服务器扩展开发。项目提供一组 C++20 API,用于注册和管理自定义物品、方块、配方、游戏规则、世界生成、战利品表、效果、实体等内容。

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Stop advertising APIs that are only placeholders

This overview tells users the library provides registration/management APIs for blocks, loot tables, effects, and entities, but the corresponding public surface is not implemented: the block/entity/loot base headers only contain #pragma once plus includes, and include/modapi/effect/CustomEffectRegistry.h is empty. Users following the README will try to build against APIs that do not exist, so please limit the feature list to implemented modules or add the missing APIs.

Useful? React with 👍 / 👎.

Comment thread README.md
Comment on lines +15 to +17
- Windows / Visual Studio C++ 工具链
- [xmake](https://xmake.io/)
- C++20 编译环境

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include Python in the build prerequisites

In a fresh Windows/Visual Studio environment that follows this list, the documented build can fail before compilation because xmake.lua runs python ./scripts/header_file_patch.py in after_load and python ./scripts/include_correction.py / format_all.py in before_build. Add Python to the required tools, including any version constraint if needed, so users know the executable must be on PATH.

Useful? React with 👍 / 👎.

Comment thread LICENSE
@@ -0,0 +1,11 @@
GNU Affero General Public License v3.0 or later

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include the full AGPL license text

This file is only a short license notice, not the complete AGPL text that the README directs users to as the full license. For source archives or offline distributions, recipients still do not receive the license terms referenced by the notice itself, so replace this with the full GNU AGPL v3 text or add a separate COPYING file and point the README there.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant