automatic advantages in subrace parameters#151
Merged
Conversation
… parameters as the other dis/advantages
elyukai
requested changes
Jun 8, 2026
elyukai
left a comment
elyukai
left a comment
Member
There was a problem hiding this comment.
Das würde nicht über CommonnessRatedAdvantageDisadvantage funktionieren, da die mehrere Optionen für eigentlich separate Einträge vereinen können. Hier bräuchten wir etwas wie bei ActivatablePrerequisite. Daher würde ich den Typ AutomaticAdvantageDisadvantage belassen und level und options aus ActivatablePrerequisite in src/types/prerequisites/single/ActivatablePrerequisite.ts übernehmen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed automatic dis/advantages in the Subrace so they take the same parameters as the other dis/advantages
Closes /issues/150