Skip to content

automatic advantages in subrace parameters #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elyukai merged 3 commits into from
Jun 8, 2026
Merged

automatic advantages in subrace parameters #151

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7b7ddb
Changed automatic dis/advantages in the Subrace so they take the same…
Lector Jun 8, 2026
ba5608e
Prettier
Lector Jun 8, 2026
9219055
Changed strongly recommended dis/advantages according to the automati…
Lector Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/types/Race.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
HairColorIdentifier,
RaceIdentifier,
} from "./_Identifier.js"
import { RequirableSelectOptionIdentifier } from "./_IdentifierGroup.js"
import { calculationContainsRaceBase, DerivedCharacteristic } from "./DerivedCharacteristic.ts"
import { ExperienceLevel } from "./ExperienceLevel.js"
import { NestedTranslationMap } from "./Locale.js"
Expand Down Expand Up @@ -195,6 +196,15 @@ const AutomaticAdvantageDisadvantage = DB.GenTypeAlias(import.meta.url, {
comment: "The automatic advantage or disadvantage.",
type: DB.TypeArgument(Identifier),
}),
level: DB.Optional({
comment: "The level of the entry.",
type: DB.Integer({ minimum: 1 }),
}),
options: DB.Optional({
comment:
"Required select options. Order is important. Typically, you only need the first array index, though.",
type: DB.Array(DB.IncludeIdentifier(RequirableSelectOptionIdentifier), { minItems: 1 }),
}),
}),
})

Expand Down Expand Up @@ -265,8 +275,7 @@ export const RaceVariant = DB.Entity(import.meta.url, {
type: DB.Array(CultureIdentifier(), { minItems: 1 }),
}),
automatic_advantages: DB.Optional({
comment:
"A list of automatically applied advantages. This does only work for advantages with no further configuration such as level or special selection.",
comment: "A list of automatically applied advantages.",
type: DB.Array(
DB.GenIncludeIdentifier(AutomaticAdvantageDisadvantage, [AdvantageIdentifier()]),
{
Expand All @@ -275,8 +284,7 @@ export const RaceVariant = DB.Entity(import.meta.url, {
),
}),
automatic_disadvantages: DB.Optional({
comment:
"A list of automatically applied disadvantages. This does only work for disadvantages with no further configuration such as level or special selection.",
comment: "A list of automatically applied disadvantages.",
type: DB.Array(
DB.GenIncludeIdentifier(AutomaticAdvantageDisadvantage, [DisadvantageIdentifier()]),
{ minItems: 1 },
Expand All @@ -285,14 +293,14 @@ export const RaceVariant = DB.Entity(import.meta.url, {
strongly_recommended_advantages: DB.Optional({
comment: "A list of strongly recommended advantages.",
type: DB.Array(
DB.GenIncludeIdentifier(CommonnessRatedAdvantageDisadvantage, [AdvantageIdentifier()]),
DB.GenIncludeIdentifier(AutomaticAdvantageDisadvantage, [AdvantageIdentifier()]),
{ minItems: 1 },
),
}),
strongly_recommended_disadvantages: DB.Optional({
comment: "A list of strongly recommended disadvantages.",
type: DB.Array(
DB.GenIncludeIdentifier(CommonnessRatedAdvantageDisadvantage, [DisadvantageIdentifier()]),
DB.GenIncludeIdentifier(AutomaticAdvantageDisadvantage, [DisadvantageIdentifier()]),
{ minItems: 1 },
),
}),
Expand Down
Loading