Bump Newton to include torque routing#6293
Conversation
Greptile SummaryThis PR bumps the
Confidence Score: 3/5Not safe to merge as-is: the upgrade from a stable PyPI Warp release to a NVIDIA-index-only dev prerelease breaks standard installs, and the PR explicitly states Kamino runtime calls will fail. The core
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[pip install isaaclab] --> B{Index configured?}
B -- PyPI only default --> C[FAIL: warp-lang dev build not on PyPI]
B -- PyPI + NVIDIA index --> D[Resolves warp-lang==1.15.0.dev20260626]
D --> E[Install newton at 49ca73b from GitHub]
E --> F{Runtime tests}
F -- Kamino solver --> G[FAIL: joint_q/joint_u removed by Newton upstream]
F -- Other paths --> H[CI reveals remaining blockers]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[pip install isaaclab] --> B{Index configured?}
B -- PyPI only default --> C[FAIL: warp-lang dev build not on PyPI]
B -- PyPI + NVIDIA index --> D[Resolves warp-lang==1.15.0.dev20260626]
D --> E[Install newton at 49ca73b from GitHub]
E --> F{Runtime tests}
F -- Kamino solver --> G[FAIL: joint_q/joint_u removed by Newton upstream]
F -- Other paths --> H[CI reveals remaining blockers]
|
| "transformers==4.57.6", | ||
| "einops", | ||
| "warp-lang==1.14.0", | ||
| "warp-lang==1.15.0.dev20260626", |
There was a problem hiding this comment.
Dev prerelease blocks standard PyPI installs
warp-lang==1.15.0.dev20260626 is not on PyPI — it is only available from https://pypi.nvidia.com. Unlike the previous warp-lang==1.14.0 (a stable PyPI release), this version requires an explicit --extra-index-url https://pypi.nvidia.com when resolving isaaclab's core dependencies. Any CI environment, Docker image, or downstream user that does pip install isaaclab without the NVIDIA extra index will fail at dependency resolution, even before reaching the known Kamino runtime failures.
| <!-- Copyright (c) 2022-2026, The Isaac Lab Project Developers (https://github.com/isaac-sim/IsaacLab/blob/main/CONTRIBUTORS.md). --> | ||
| <!-- All rights reserved. --> | ||
| <!-- SPDX-License-Identifier: BSD-3-Clause --> | ||
|
|
||
| # Newton Latest-Pin Compatibility Probe |
There was a problem hiding this comment.
Non-standard documentation directory
docs/superpowers/specs/ is created for the first time by this PR and contains only this one file. Standard Isaac Lab design and spec content lives under docs/source/. An isolated new top-level subtree with no cross-references from the rendered docs site will be hard to discover and may accumulate stale specs over time. If this is intentional, a README or index explaining the superpowers/ convention would help future contributors understand its purpose.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
ce0672e to
819e9bd
Compare
5b004bd to
6d7b406
Compare
Description
Pins every active
newton[sim]dependency to Newton commit2064e3b79807dcc1679d1eb86ef7efd9ef0f28ee, the squash-merge commit forNewton PR #3134. The
update also changes the core IsaacLab Warp requirement from
1.14.0to theprerelease build
1.15.0.dev20260626.This branch is based on the reviewed
origin/developsnapshote5478465baf58f735ba308e40faf6b4eb2993d29.Upstream comparison from the prior pin to the new pin:
newton-physics/newton@49ca73b...2064e3b
Compatibility updates
wp.float32viewsbefore copying, matching Warp 1.15 element-size validation.
model.shape_marginthrough the MJWarp/VBD and Featherstone/VBDreaction paths, with regression coverage for both solvers.
SolverKamino.ResetConfig.from_joints()whilekeeping the reset migration minimal.
IsaacLab adds no custom Kamino torque-routing path. Newton PR #3134 consumes
the generic
Control.joint_feffort input upstream. IsaacLab retains only itsKamino lifecycle, reset, forward-kinematics, collision, and graph
specialization.
Local verification
Exact local environment: Newton
2064e3b79807dcc1679d1eb86ef7efd9ef0f28ee, Warp1.15.0.dev20260626.exit code 0, no traceback, and
Training time: 2.83 seconds. This provesruntime/integration compatibility of the generic effort path; it does not
establish numerical torque effectiveness.
./isaaclab.sh -f: passed before and after the final commit.Local COM coverage gap
The focused kitless COM fallback run produced 76 passed, 520 deselected,
28 setup errors, and 0 skipped. The 28 setup errors are a pre-existing
OVPhysX fixture/API mismatch:
mock_bindings.bindingsis a dictionary wherethe fixture expects an object exposing
.view. They are not a failure causedby this pin, but the affected COM assertions remain a disclosed local coverage
gap. The final-head CI matrix will be authoritative once terminal.
CI result
Current head
6d7b40682a2117a28ff4fb2dff7a8aaadca75b2e, based on reviewedorigin/developsnapshote5478465baf58f735ba308e40faf6b4eb2993d29:CI pending for this rebased head. Historical results below are from
pre-rebase head
5b004bd04e79d735324ae64c9d4210f79b77c519and are retained asdiagnostic context; they are not the final-head result.
On pre-rebase head
5b004bd04e79d735324ae64c9d4210f79b77c519, thecompatibility-focused jobs passed, including
isaaclab_newton,isaaclab_physx,isaaclab_contrib, all core and task shards, bothinstallation jobs, and
isaaclab_ovon unchanged rerun.Original and rerun evidence
isaaclab_ovoriginalfailed the GPU
test_body_root_state_properties[True-cuda:0-1]numericalvelocity comparison after its three built-in attempts: the final maximum
absolute difference was
0.000190109for a0.0001tolerance. Theunchanged rerun
passed, confirming this as known intermittent and non-blocking.
rendering-correctness-kitlessoriginalexhausted its built-in attempts for an OVPhysX Cartpole diffuse comparison
(
2.38%different pixels versus a1.00%limit) and a Newton Dexsuitefull-MDL comparison (
10.37%versus8.00%). Both original cases passedon the unchanged rerun,
while a different Newton Cartpole normals comparison exhausted its attempts
(
2.39%versus1.00%, final SSIM0.9566). An independently triggeredunchanged attempt 3
passed. The shifting failures followed by a clean rerun confirm this as a
known intermittent, non-blocking rendering flake.
test-curobooriginalwas cancelled when its runner received a shutdown signal during OCI export,
followed by an RPC
Unavailable/EOF. Theunchanged rerun
passed, confirming an infrastructure-only transient.
The final branch delta from reviewed base
e5478465baf58f735ba308e40faf6b4eb2993d29touches the OV/PhysX COM stagingsources listed above but does not modify rendering test or baseline files.
Because the reviewed base includes Cartpole lighting and rendering test/golden
updates, final-head rendering CI is an important integration check.
The CI matrix does not make the locally blocked COM assertions pass and does
not close the clean-wheel
[newton]installation coverage gap; both remaindocumented separately.
Remaining installation coverage gap
Current installation CI does not clean-install a built wheel with the
[newton]extra. End-to-end resolution of the generated Git Newton URL plusthe prerelease Warp build from the NVIDIA index remains untested by that path.