feat(react-tags): decouple useTagGroupBase_unstable from Tabster + export contexts#36228
Open
mainframev wants to merge 3 commits into
Open
feat(react-tags): decouple useTagGroupBase_unstable from Tabster + export contexts#36228mainframev wants to merge 3 commits into
mainframev wants to merge 3 commits into
Conversation
This was referenced May 19, 2026
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1204 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 481 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium.png | 481 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1089 | Changed |
vr-tests-react-components/Charts-DonutChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 7530 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 609 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 509 | Changed |
vr-tests-react-components/ProgressBar converged 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 42 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 36 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 54 | Changed |
vr-tests-react-components/TagPicker 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
mainframev
force-pushed
the
feat/headless-tag-1-refactor
branch
from
99f8a77 to
24a9f85
Compare
mainframev
force-pushed
the
feat/headless-tag-1-refactor
branch
from
24a9f85 to
4af8734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
This PR is part of a 3-PR stack. Review and merge bottom-up:
master) — merge firstSummary
useTagGroupBase_unstablefrom@fluentui/react-tabsterand@fluentui/react-shared-contexts. Arrow-key navigation and post-dismiss focus restoration are now pluggable via a new optionalUseTagGroupBaseOptionsargument (arrowNavigationProps,onAfterTagDismiss), mirroring theuseMenuTriggerBase_unstablepattern. The styleduseTagGroup_unstablekeeps full behaviour by supplying Tabster-backed implementations through that options bag.TagGroupContextProvider/useTagGroupContext_unstable,InteractionTagContextProvider/useInteractionTagContext_unstable, and theTagGroupContextValue/InteractionTagContextValuetypes. Also re-exports the previously-missingTagContextValuestype.