test(react-tags): add hook regression tests for Tag family#36229
Open
mainframev wants to merge 3 commits into
Open
test(react-tags): add hook regression tests for Tag family#36229mainframev wants to merge 3 commits into
mainframev wants to merge 3 commits into
Conversation
This was referenced May 19, 2026
9a05d90 to
36292c8
Compare
|
Pull request demo site: URL |
99f8a77 to
24a9f85
Compare
36292c8 to
f368d08
Compare
77859e1 to
495dfb9
Compare
495dfb9 to
1d660cc
Compare
24a9f85 to
4af8734
Compare
1d660cc to
14b9a10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
This PR is part of a 3-PR stack. Review and merge bottom-up:
master) — merge firstSummary
Adds
renderHook-based regression tests for the Tag, InteractionTag, InteractionTagPrimary, InteractionTagSecondary, and TagGroup base + styled hooks. Locks in the public output shape so subsequent base-hook refactors (such as the Tabster decoupling in #36228) cannot silently regress the styled hooks.Coverage highlights:
root.type(button vs span), event-handler presence/absenceDismissRegularinjection happens only in the styled hooks (useTag_unstable,useInteractionTagSecondary_unstable), never in the base hooksappearance/sizefromTagGroupContextdisabled(group overrides tag prop)UseTagGroupBaseOptionscontract:arrowNavigationPropsis spread onto root,onAfterTagDismissis invoked after a dismiss; both default to no-oparia-selected(listbox),aria-pressed(default),aria-labelledby(InteractionTagSecondary)Stack created with GitHub Stacks CLI • Give Feedback 💬