feat(acceptance): version-aware pull-wait for edge ArgoCD (no argocd-sync)#4
Merged
Merged
Conversation
…sync) Add expected_version (+ version_url / version_header) so the curl poll also gates on the promoted version being LIVE before passing — the check waits for the edge cluster's own ArgoCD to pull + roll out the new image, with no argocd-sync / no ArgoCD API token. Without it the poll false-greens against the old pod (identical body). Version match is grep -F (tags contain dots); reads body or a response header. Back-compat: expected_version empty → acceptance_text-only behavior unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the
acceptance-test-curlreusable into a pull-wait gate for the v2.0 edge-ArgoCD model: setexpected_versionand the poll also waits until the app is serving that version before passing — so it waits for the edge cluster's own ArgoCD to pull + roll out the promoted image, with noargocd-syncand no ArgoCD API token.version_header, e.g.X-App-Version); separateversion_urloptional.grep -F(tags contain dots). Back-compat:expected_versionempty → unchanged.Completes opsta-ai-pe v2.0 S4 (with #2 cross-repo gitops-deploy + #3 crane cross-registry bridge).
🤖 Generated with Claude Code