feat(crane): cross-registry bridge for v2.0 cross-provider promote#3
Merged
Merged
Conversation
Add dst_image + dst_registry_username/password so the crane retag Job can copy <image>:<tag_from> → <dst_image>:<tag_to> across DIFFERENT registries (k3d↔AR for the s3/s4 cross-provider scenarios), not just within one. Source/dest auth are independent, merged into one docker config (auths keyed by host) so crane authenticates each side; a no-auth side (k3d HTTP + registry_insecure) omits its creds. ENV is additive (DOCKER_CONFIG + GCE_METADATA_HOST can coexist: basic-auth side + WI side). dst_image defaults to image → existing single-registry callers unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
winggundamth
added a commit
that referenced
this pull request
Jun 21, 2026
…istry) (#6) Add registry_username/password secrets + a basic-auth branch: when no Workload-Identity SA but a registry password is present, build a docker config (auths keyed by registry host) and mount it so kaniko can push to a private basic-auth registry (e.g. a Harbor robot). Mutually exclusive with the WI SA path; k3d insecure path unchanged. Completes the registry-flexibility set: build (this) + promote/bridge (crane #3) now both speak basic-auth, so nonprod=Harbor / prod=cloud works end-to-end. Co-authored-by: Jirayut Nimsaeng (Dear) <jirayut@opsta.co.th> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
dst_image+dst_registry_username/passwordto thetagging-container-image-cranereusable so promote-by-retag can copy across registries (k3d local ↔ Artifact Registry) for the v2.0 cross-provider scenarios (s3: k3d→gke, s4: gke→k3d) — not just within one registry.authskeyed by registry host); a no-auth side (k3d HTTP +registry_insecure) omits creds.dst_imagedefaults toimage→ existing single-registry callers unchanged.Part of opsta-ai-pe v2.0 (S4). Companion to #2 (cross-repo gitops-deploy). Next: pull-wait acceptance (edge ArgoCD).
🤖 Generated with Claude Code